Skip to content

refactor to records #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanjbaxter merged 1 commit into from
Jul 7, 2026
+4 −56
Merged

refactor to records #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions ...org/springframework/cloud/kubernetes/configuration/watcher/ConfigMapKubernetesSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,13 @@
/**
* @author wind57
*/
final class ConfigMapKubernetesSource implements KubernetesSource {
record ConfigMapKubernetesSource(Set<String> serviceNames, Map<String, String> serviceLabels,
String resourceName) implements KubernetesSource {

static final String CONFIGMAP_SERVICE_NAMES_ANNOTATION = "spring.cloud.kubernetes.configmap.apps";

static final String CONFIGMAP_SERVICE_LABELS_ANNOTATION = "spring.cloud.kubernetes.configmap.labels";

private final Set<String> serviceNames;

private final Map<String, String> serviceLabels;

private final String resourceName;

ConfigMapKubernetesSource(Set<String> serviceNames, Map<String, String> serviceLabels, String resourceName) {
this.serviceNames = serviceNames;
this.serviceLabels = serviceLabels;
this.resourceName = resourceName;
}

@Override
public String resourceName() {
return resourceName;
}

@Override
public String description() {
return "configmap";
Expand All @@ -55,16 +39,6 @@ public String requiredResourceLabel() {
return ConfigurationWatcherConfigurationProperties.CONFIG_MAP_LABEL;
}

@Override
public Set<String> serviceNames() {
return serviceNames;
}

@Override
public Map<String, String> serviceLabels() {
return serviceLabels;
}

@Override
public String toString() {
return "ConfigMapKubernetesSource{" + "resourceName='" + resourceName + '\'' + ", serviceNames=" + serviceNames
Expand Down
30 changes: 2 additions & 28 deletions ...va/org/springframework/cloud/kubernetes/configuration/watcher/SecretKubernetesSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,13 @@
/**
* @author wind57
*/
final class SecretKubernetesSource implements KubernetesSource {
record SecretKubernetesSource(Set<String> serviceNames, Map<String, String> serviceLabels,
String resourceName) implements KubernetesSource {

static final String SECRET_SERVICE_NAMES_ANNOTATION = "spring.cloud.kubernetes.secret.apps";

static final String SECRET_SERVICE_LABELS_ANNOTATION = "spring.cloud.kubernetes.secret.labels";

private final Set<String> serviceNames;

private final Map<String, String> serviceLabels;

private final String resourceName;

SecretKubernetesSource(Set<String> serviceNames, Map<String, String> serviceLabels, String resourceName) {
this.serviceNames = serviceNames;
this.serviceLabels = serviceLabels;
this.resourceName = resourceName;
}

@Override
public String resourceName() {
return resourceName;
}

@Override
public String description() {
return "secret";
Expand All @@ -55,16 +39,6 @@ public String requiredResourceLabel() {
return ConfigurationWatcherConfigurationProperties.SECRET_LABEL;
}

@Override
public Set<String> serviceNames() {
return serviceNames;
}

@Override
public Map<String, String> serviceLabels() {
return serviceLabels;
}

@Override
public String toString() {
return "SecretKubernetesSource{" + "resourceName='" + resourceName + '\'' + ", serviceNames=" + serviceNames
Expand Down
Loading