fix callbacks for user updates #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes updating user. Most of user data which is sent to mailchimp comes from his bill address, due to that user update request should be sent also when his bill address is updated.
This PR also reduces amount of requests to mailchimp when user is updated. User update request will be sent only when one of attributes which is sent to mailchimp is changed (see User Presenter).
Also, this PR fixes updating user email. The issue is that we create mailchimp user id based on his email (here). So when user email is changed, his uniqe id also changes and
spree_mailchimp_ecommerceis unable to find the existing user in mailchimp. I created a solution for that inapp/jobs/spree_mailchimp_ecommerce/update_user_job.rb.I could fix a way of creating mailchimp user id, but then existing mailchimp databases would have duplicated users.