Ensures a common interface for utils #190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2018 16:22
Previously two disperate objects could be passed into utils, a `Gateway` or a `provider`. This changes the signature to always expect a `gateway` It reduces the potential impact of this change from causing a double lookup by lazy loading utils. There are most likely additional refactors that are required here but this allows the utils class not swallow unrelated errors.
|
Both of the errors in style, and the failing spec are unrelated. The spec is failing as this rescue was rescuing things it shouldn't have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously two disperate objects could be passed into utils, a
Gatewayor a
Provider. This changes the signature to always expect aGatewayIt reduces the potential impact of this change from causing a double
lookup by lazy loading utils.
There are most likely additional refactors that are required here but
this allows the utils class not swallow unrelated errors.