Add QR-Code options method

[sdespont]

Details #249

[sdespont]

@sprain, what's the point of automatically executing tests in the workflow if they can't succeed? This test only works in a hardened environment”. Does that help?

[kohlerdominik]

I think the test fails because "prefer-lowest" will go for the lowest allowed endroid-version, which is 4.4.4, and this version does not have Endroid\QrCode\Writer\SvgWriter::WRITER_OPTION_COMPACT I guess?

The fix would be to remove endroid/qr-code: ^4.4.4 from composer.json. Is there reason to keep the compatibility?

[sdespont]

I think we should drop EOL PHP 8.0 permitting to drop endroid/qr-code: ^4

@sprain ok for you ?

[sprain]

I am not keen on exposing Endroid functionality outside of our own QrCode class. The goal was to keep all qr code functionality encased there.

I would prefer if we could add the additional option within QrCode, with a more specific method name – maybe as simple as $qrCode->optimizeForTcPdfOutput(), which then adds the required option.

[sprain]

Thanks for the PR!

I think we should drop EOL PHP 8.0 permitting to drop endroid/qr-code: ^4

I remember the backlash when I dropped support for endroid/qr-code: ^3 too soon 😅

PHP 8.0 still counts for 20% of all installs of this library, and even 25% for v4 of this library.
In addition, endroid/qr-code: ^4 is still the most used version of that dependency by far, so dropping support might bring trouble for some projects.

Therefore, the way to go would be to add parallel support for both versions, before dropping the older one. We already do that in the constructor of QrCode.

[sdespont]

ok, it means that Endroid\QrCode\Writer\SvgWriter::WRITER_OPTION_COMPACT cannot be used and we need to harcode the option key "compact" instead. I have pushed a commit for that

[sprain]

ok, it means that Endroid\QrCode\Writer\SvgWriter::WRITER_OPTION_COMPACT cannot be used and we need to harcode the option key "compact" instead. I have pushed a commit for that

That's not what I meant :) This still couples TcPdfOuput directly to the Endroid library, which I want to avoid.

But I can take over from here, no worries.

[kohlerdominik]

@sprain Tests in prefer-stable & >8.1 are not only failing, but also taking >15Minutes compared to the <15Seconds that they used to take.

There seems to be a significant issue with one of the dependencies. So once the tests are fixed, please also keep an eye on the runtime.

[sprain]

Replaced by #252