Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty line before alternative schemes, if needed #240

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

sprain
Copy link
Owner

@sprain sprain commented Nov 9, 2023

Fixes #142
See #142 (comment)

Fixes a situation where an additional empty line needs to be added if there is no billInformation but there are alternativeSchemes.

@demianh
Copy link

demianh commented Nov 15, 2023

I can confirm this solves my problem from #142 (comment)

@demianh
Copy link

demianh commented Nov 15, 2023

The validator shows a warning (not an error!) for the generated QR code:

(0048) - Element must only be deliverd if the element ist not empty. Exception: If subsequent elements are provided.

But i guess, that is a problem of the validator, that it can't handle the Exception.

Full validator output: Protocol.txt

@sprain
Copy link
Owner Author

sprain commented Nov 15, 2023

Thanks for testing!

I am pretty sure that the validator is currently broken. I am in touch with SIX. See #241.

I will give them a few more days to get back to me again. Maybe we can then merge this with successfully validated qr codes.

Update: The most urgent validator issues seem to be fixed. The warning IMO is still a bug in the validator and I will let them know about it again. See screenshots validator vs. documentation.

«Hinweis» on validation is likely a remaining issue of the validator, not understanding that StrdBkgInf (line 32) happens to be empty when it has no value, but alternative schemes are provided.
@sprain
Copy link
Owner Author

sprain commented Nov 16, 2023

Ok, SIX replied. This state of things is the best they can do in the validator. The warning will always be shown, even if the exception applies.

@sprain sprain merged commit eb68c11 into master Nov 16, 2023
14 checks passed
@sprain sprain deleted the empty-line-before-alternative-schemes branch November 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of StrdBkgInf changed in specifications v2.2
2 participants