Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan issues, upgrade to latest phpstan release #235

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix phpstan issues, upgrade to latest phpstan release #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"fpdf/fpdf": "^1.85",
"friendsofphp/php-cs-fixer": "^3.15",
"khanamiryan/qrcode-detector-decoder": "^1.0.3",
"phpstan/phpstan": "^1.2",
"phpstan/phpstan": "^1.10.37",
"setasign/fpdi": "^2.3.5",
"setasign/fpdf": "^1.8.2",
"tecnickcom/tcpdf": "^6.3.2"
Expand Down
17 changes: 10 additions & 7 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@ parameters:
level: 6
paths:
- src/
ignoreErrors:
- '#Parameter \#1 \$h of method TCPDF::setCellHeightRatio\(\) expects int, float given\.#'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is fixed already, not reported anymore

reportUnmatchedIgnoredErrors: false
reportUnmatchedIgnoredErrors: false
2 changes: 1 addition & 1 deletion src/QrBill.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ private function getQrCodeContent(): string
}

/**
* @param list<QrCodeableInterface|list<QrCodeableInterface>> $elements
* @param list<QrCodeableInterface|AddressInterface|list<AddressInterface|QrCodeableInterface>> $elements
* @return list<string|int|null>
*/
private function extractQrCodeDataFromElements(array $elements): array
Expand Down