This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
GKE + CloudSQL deployment added #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balaji
reviewed
Dec 7, 2020
d4nilos
reviewed
Dec 7, 2020
|
|
||
| ```bash | ||
| gcloud sql instances create ${DB_INSTANCE_NAME} \ | ||
| --database-version=POSTGRES_9_6 \ |
There was a problem hiding this comment.
Since we are doing this, maybe it's interesting to use Cloud SQL on Postgres version 13 instead of 9.6.
What do you think?
It has a bunch of interesting performance improvements.
E.g. Smaller indexes and quicker queries.
There was a problem hiding this comment.
I was not sure if there are any specific dependencies on version 9.6. If the dev team is OK with version 13, I can do the change :-)
Co-authored-by: Danilo Augusto Silva <[email protected]>
Co-authored-by: Danilo Augusto Silva <[email protected]>
Co-authored-by: Danilo Augusto Silva <[email protected]>
balaji
reviewed
Dec 8, 2020
balaji
reviewed
Dec 8, 2020
balaji
approved these changes
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since many of us already have a GKE cluster running, I thought it might be a good idea to have a set of deployment YAMLs with a step by step howto for this deployment