Skip to content

Commit

Permalink
Setting back some items I tried testing that didn't work out. (#1100)
Browse files Browse the repository at this point in the history
* [pom] Delete the plugin management as that didn't help solve issue

* [ci] Put sonar token back how it was
  • Loading branch information
hazendaz authored Nov 28, 2024
1 parent 406d900 commit 0b78996
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/sonarqube.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
# previous LTS version
SONAR_SERVER_VERSION: 9.9.7.96285
SONAR_PLUGIN_API_VERSION: 9.14.0.375
SONAR_TOKEN: $SONAR_TOKEN
steps:
- name: Decide the ref to check out
uses: haya14busa/action-cond@v1
Expand Down Expand Up @@ -65,6 +64,7 @@ jobs:
-Dsonar.projectKey=com.github.spotbugs:sonar-findbugs-plugin \
-Dsonar.organization=spotbugs \
-Dsonar.host.url=https://sonarcloud.io \
-Dsonar.token=$SONAR_TOKEN \
${PR_NUMBER:+ -Dsonar.pullrequest.key=$PR_NUMBER -Dsonar.pullrequest.branch=$PR_BRANCH }
env:
GITHUB_TOKEN: ${{ secrets.PAT_TO_FORK }}
Expand Down
10 changes: 0 additions & 10 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,6 @@
<maven.compiler.release>8</maven.compiler.release>
</properties>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.sonarsource.api.plugin</groupId>
<artifactId>sonar-plugin-api</artifactId>
<version>9.14.0.375</version>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<!--
!!! ORDER OF DEPENDENCIES IS IMPORTANT !!!
Expand Down

0 comments on commit 0b78996

Please sign in to comment.