Fix fresh install splunk vs upgrade (#726)

Upgrade qualifies only fro a first run. And clean up home dir for fresh install

roles/splunk_common/tasks/get_facts.yml

@@ -79,7 +79,7 @@
 # and allowing upgrades between new and old hashes of the same version.
 - name: "Setting upgrade fact"
   set_fact:
-    splunk_upgrade: "{{ 'build_location' in splunk and splunk.build_location and not splunk_install and splunk_target_version and ((splunk_target_version != splunk_current_version) or (splunk_current_build_hash != splunk_target_build_hash))| default(False) }}"
+    splunk_upgrade: "{{ not first_run and 'build_location' in splunk and splunk.build_location and not splunk_install and splunk_target_version and ((splunk_target_version != splunk_current_version) or (splunk_current_build_hash != splunk_target_build_hash))| default(False) }}"
 
 # determine if we need to set up indexer clusters
 - name: "Setting indexer cluster fact from config"

roles/splunk_common/tasks/install_splunk.yml

@@ -24,6 +24,26 @@
     - "{{ splunk.home }}/Python-2.7"
   when: splunk_upgrade | bool
 
+- name: Find all files to clean up in Splunk home for fresh install
+  find:
+    path: "{{ splunk.home }}"
+    file_type: file
+  ignore_errors: yes
+  become: yes
+  become_user: "{{ privileged_user }}"
+  register: cleanup_files
+  when: not splunk_upgrade
+
+- name: Clean up Splunk home for fresh install
+  file:
+    path: "{{ item.path }}"
+    state: "absent"
+  ignore_errors: yes
+  become: yes
+  become_user: "{{ privileged_user }}"
+  with_items: "{{ cleanup_files.files }}"
+  when: not splunk_upgrade
+
 - name: Install Splunk
   include_tasks: install_splunk_{{ splunk_build_type }}.yml