VULN-63051: version upgrade for opentelemetry-go from v1.33 to 1.40.0#78
VULN-63051: version upgrade for opentelemetry-go from v1.33 to 1.40.0#78kupratyu-splunk merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Go module dependencies to remediate the OpenTelemetry-Go SDK macOS PATH hijacking vulnerability by moving to go.opentelemetry.io/otel v1.40.0, and tweaks test suites to be skippable when required external dependencies (cluster / envtest assets) are unavailable so go test ./... can succeed in more environments.
Changes:
- Bump OpenTelemetry-Go (and related transitive deps) to
v1.40.0. - Update additional Go dependencies as part of the module resolution/tidy.
- Add “skip if prerequisites missing” logic to e2e and controller Ginkgo suites.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
go.mod |
Updates OTel + other dependency versions to pick up the vulnerability fix. |
go.sum |
Refreshes module checksums to match the upgraded dependency graph. |
test/e2e/specs/spec_suite_test.go |
Skips the e2e suite when kubectl cluster-info fails (intended to allow go test ./... without a live cluster). |
internal/controller/suite_test.go |
Skips controller envtest suite when envtest binaries aren’t present and KUBEBUILDER_ASSETS is unset; avoids teardown when setup didn’t run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 22839939213Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR upgrades OpenTelemetry-related dependencies and adds a bounded timeout and skip when the cluster is unreachable so e2e specs do not block indefinitely
OpenTelemetry-Go is the Go implementation of OpenTelemetry. The OpenTelemetry Go SDK in version v1.20.0-1.39.0 is vulnerable to Path Hijacking (Untrusted Search Paths) on macOS/Darwin systems. The resource detection code in sdk/resource/host_id.go executes the ioreg system command using a search path. An attacker with the ability to locally modify the PATH environment variable can achieve Arbitrary Code Execution (ACE) within the context of the application. A fix was released with v1.40.0.
Related Issues
Type of Change
Changes Made
Testing Performed
make test)make lint)Test Environment
Test Steps
Documentation
Checklist
Breaking Changes
Impact:
Migration Path:
Screenshots/Recordings
Additional Notes
Reviewer Notes
Please pay special attention to:
Commit Message Convention: This PR follows Conventional Commits