Setup Script Updates: EKS script removes eksctl dependency for install#74
Open
rlieberman-splunk wants to merge 3 commits intomainfrom
Open
Setup Script Updates: EKS script removes eksctl dependency for install#74rlieberman-splunk wants to merge 3 commits intomainfrom
rlieberman-splunk wants to merge 3 commits intomainfrom
Conversation
Pull Request Test Coverage Report for Build 20148552881Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR introduces a --no-eksctl flag to the EKS cluster setup script, allowing users to set up the AI platform on pre-existing EKS clusters that were created outside of eksctl. The changes conditionally skip eksctl-dependent operations (OIDC provider setup, service account creation, and addon installation) when this flag is present, while providing clear error messages directing users to perform these setup steps manually.
Key Changes:
- Added
--no-eksctlcommand-line flag with argument parsing logic - Wrapped all eksctl commands in conditional blocks that check the
USE_EKSCTLflag - Updated documentation with prerequisites for manual cluster setup without eksctl
- Fixed unrelated bugs: corrected Splunk service name in port-forward command and removed non-existent status command
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
tools/cluster_setup/eks_cluster_with_stack.sh |
Added USE_EKSCTL flag and conditional logic around eksctl commands in OIDC setup, EBS CSI addon installation, service account creation, and preflight checks; added argument parsing for --no-eksctl flag |
tools/cluster_setup/EKS_README.md |
Added comprehensive prerequisites for --no-eksctl mode including required IAM service accounts, policies, and cluster configuration; fixed Splunk service name; removed reference to non-existent status command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the cluster setup for AWS EKS clusters, and the accompanying README for the script. The script now includes an option
--no-eksctlfor customers that setup their cluster and IRSA separately, but still want an automated script to setup the ai platform.Related Issues
Type of Change
Changes Made
eks_cluster_with_stack.sh: add new--no-eksctloption, only run eksctl commands if option is not present.EKS_README.md: add instructions on what needs to be setup on the cluster before running the script if not using eksctl.Testing Performed
make test)make lint)Test Environment
Test Steps
CONFIG_FILE=./cluster-config.yaml ./eks_cluster_with_stack.sh install --no-eksctland verified the system was setup.Documentation
Checklist
Breaking Changes
Impact:
Migration Path:
Screenshots/Recordings
Additional Notes
Reviewer Notes
Commit Message Convention: This PR follows Conventional Commits