Merged
Conversation
…operator into validate-fixme
updating for workspec update and remove fluentbit
Validation and unit test cases
Docker validation
Fix setup script for linux
fix upload script config
Follow OSS standards for documentation, workflows
scai-splunk
approved these changes
Nov 18, 2025
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 107 out of 148 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+632
to
+638
| old_val, ok := instanceScale[k] | ||
| if ok { | ||
| instanceScale[k] = old_val + val | ||
| } else { | ||
| instanceScale[k] = val | ||
| } | ||
| } |
There was a problem hiding this comment.
[nitpick] The variable old_val is only used when ok is true. Consider using if oldVal, ok := instanceScale[k]; ok to limit scope and improve readability.
Suggested change
| old_val, ok := instanceScale[k] | |
| if ok { | |
| instanceScale[k] = old_val + val | |
| } else { | |
| instanceScale[k] = val | |
| } | |
| } | |
| if old_val, ok := instanceScale[k]; ok { | |
| instanceScale[k] = old_val + val | |
| } else { | |
| instanceScale[k] = val | |
| } | |
| } | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.