orgsvc: add pagination to ListMembers - #20
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
WalkthroughThe member listing proto adds request fields for page size and continuation tokens, plus a response field indicating the cursor for a subsequent page. ChangesMember listing pagination
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
Add limit + cursor to ListMembersRequest.Base and next_cursor to ListMembersResponse, so the public ListMembers surface exposes the same cursor pagination the priv implementation already ships. Field numbers match the priv-side override (limit=2, cursor=3, next_cursor=2) so the override stays a pure signed-envelope overlay. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Konyaka1
force-pushed
the
aliaksei/list-members-pagination
branch
from
July 18, 2026 04:10
fade726 to
7649f48
Compare
Konyaka1
marked this pull request as ready for review
July 20, 2026 13:59
geffrak
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds cursor pagination to the public
ListMemberssurface:limit+cursoronListMembersRequest.Baseandnext_cursoronListMembersResponse. The priv implementation already ships this pagination via a priv-side override; this graduates the fields into the public source of truth so the public contract matches. Field numbers (limit=2,cursor=3,next_cursor=2) match the override so it stays a pure signed-envelope overlay.Protos
proto/splitsecure/orgsvc/v1/list_members.proto: newlimit/cursor/next_cursorfields with doc comments.Generated
gen/goandgen/esforlist_membersviabuf generate.🤖 Generated with Claude Code