Skip to content

orgsvc: add pagination to ListMembers - #20

Merged
Konyaka1 merged 1 commit into
mainfrom
aliaksei/list-members-pagination
Jul 20, 2026
Merged

orgsvc: add pagination to ListMembers#20
Konyaka1 merged 1 commit into
mainfrom
aliaksei/list-members-pagination

Conversation

@Konyaka1

Copy link
Copy Markdown
Contributor

Summary

Adds cursor pagination to the public ListMembers surface: limit + cursor on ListMembersRequest.Base and next_cursor on ListMembersResponse. The priv implementation already ships this pagination via a priv-side override; this graduates the fields into the public source of truth so the public contract matches. Field numbers (limit=2, cursor=3, next_cursor=2) match the override so it stays a pure signed-envelope overlay.

Protos

  • proto/splitsecure/orgsvc/v1/list_members.proto: new limit/cursor/next_cursor fields with doc comments.

Generated

  • Regenerated gen/go and gen/es for list_members via buf generate.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 18, 2026, 4:11 AM

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The member listing proto adds request fields for page size and continuation tokens, plus a response field indicating the cursor for a subsequent page.

Changes

Member listing pagination

Layer / File(s) Summary
Pagination message fields
proto/splitsecure/orgsvc/v1/list_members.proto
ListMembersRequest.Base adds server-clamped limit and opaque cursor fields; ListMembersResponse adds next_cursor for subsequent pages.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding pagination to ListMembers.
Description check ✅ Passed The description is directly related to the changeset and accurately describes the new pagination fields and regenerated protos.

Comment @coderabbitai help to get the list of available commands.

Add limit + cursor to ListMembersRequest.Base and next_cursor to
ListMembersResponse, so the public ListMembers surface exposes the same
cursor pagination the priv implementation already ships. Field numbers
match the priv-side override (limit=2, cursor=3, next_cursor=2) so the
override stays a pure signed-envelope overlay.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Konyaka1
Konyaka1 force-pushed the aliaksei/list-members-pagination branch from fade726 to 7649f48 Compare July 18, 2026 04:10
@Konyaka1
Konyaka1 marked this pull request as ready for review July 20, 2026 13:59
@Konyaka1
Konyaka1 requested review from geffrak and laura-splits July 20, 2026 13:59
@Konyaka1
Konyaka1 added this pull request to the merge queue Jul 20, 2026
Merged via the queue into main with commit d727ff2 Jul 20, 2026
3 checks passed
@Konyaka1
Konyaka1 deleted the aliaksei/list-members-pagination branch July 20, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants