Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A data fusion inspired traversal API for expressions #1828

Merged
merged 12 commits into from
Jan 7, 2025

Conversation

joseph-isaacs
Copy link
Member

@joseph-isaacs joseph-isaacs commented Jan 6, 2025

This could later be used for other hierarchies

@joseph-isaacs joseph-isaacs marked this pull request as draft January 6, 2025 17:02
@joseph-isaacs joseph-isaacs changed the title idea: traverse expr idea: traversal vortex-expr Jan 6, 2025
@joseph-isaacs joseph-isaacs changed the title idea: traversal vortex-expr wip: traversal vortex-expr Jan 6, 2025
# Conflicts:
#	vortex-expr/src/binary.rs
#	vortex-expr/src/like.rs
#	vortex-expr/src/not.rs
#	vortex-expr/src/project.rs
#	vortex-expr/src/pruning.rs
# Conflicts:
#	vortex-expr/src/binary.rs
#	vortex-expr/src/like.rs
#	vortex-expr/src/not.rs
#	vortex-expr/src/project.rs
#	vortex-expr/src/pruning.rs
@joseph-isaacs joseph-isaacs changed the title wip: traversal vortex-expr A data fusion inspired traversal API for expressions Jan 7, 2025
@joseph-isaacs joseph-isaacs marked this pull request as ready for review January 7, 2025 13:51
@joseph-isaacs joseph-isaacs requested a review from danking January 7, 2025 15:17
Copy link
Member

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks great. Hail used the exact same scheme to modify children though our traversal (iirc) only supported top-down, non-short-circuiting traversals.

# Conflicts:
#	vortex-expr/src/lib.rs
#	vortex-expr/src/select.rs
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 7, 2025 17:50
@joseph-isaacs joseph-isaacs disabled auto-merge January 7, 2025 18:12
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 7, 2025 18:12
@joseph-isaacs joseph-isaacs merged commit 6437b41 into develop Jan 7, 2025
21 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/traverse-expr branch January 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants