Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize FoRArray compare #1656

Merged
merged 5 commits into from
Jan 7, 2025
Merged

feat: optimize FoRArray compare #1656

merged 5 commits into from
Jan 7, 2025

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 12, 2024 •
edited by lwwmanning
Loading

Fixes #1570
Fixes #1420

AdamGS
AdamGS previously requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@AdamGS AdamGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@lwwmanning lwwmanning changed the title FoR compare feat: optimize FoRArray compare Jan 7, 2025
@lwwmanning lwwmanning enabled auto-merge (squash) January 7, 2025 15:34
@lwwmanning lwwmanning mentioned this pull request Jan 7, 2025
Closed
@lwwmanning lwwmanning merged commit 116de09 into develop Jan 7, 2025
21 checks passed
@lwwmanning lwwmanning deleted the ngates/for-compare branch January 7, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doki23 doki23 doki23 left review comments

@lwwmanning lwwmanning lwwmanning approved these changes

@AdamGS AdamGS AdamGS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement FoR::compare
4 participants
@gatesn @lwwmanning @AdamGS @doki23