Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Singleton attribute instead of SingletonInterface #15

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

msmakouz
Copy link
Member

Related to: spiral/framework#1056

@msmakouz msmakouz added the enhancement New feature or request label Jan 10, 2024
@msmakouz msmakouz self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3c06ad) 95.47% compared to head (f392ece) 96.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
+ Coverage     95.47%   96.10%   +0.63%     
- Complexity      292      302      +10     
============================================
  Files            35       35              
  Lines           552      642      +90     
============================================
+ Hits            527      617      +90     
  Misses           25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 3858b8f into master Jan 11, 2024
9 checks passed
@butschster butschster deleted the singleton-interface branch January 11, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants