Synchronize Query Parameters Between ServerRequest
and Uri
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
FakeHttp
class, developers can specify query strings in two ways:This flexibility, however, can lead to potential inconsistencies when both methods are used simultaneously. It's crucial to ensure coherency between the query parameters of the
Psr\Http\Message\UriInterface
class and thePsr\Http\Message\ServerRequestInterface
class.This PR modifies the
createRequest
method of theFakeHttp
class to address this inconsistency:Uri
inServerRequest
has any query parameters.createRequest
method, ensuring a comprehensive and consistent set of query parameters.