-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Temporal Connection Configuration with SSL Support and Flexibility #83
base: 3.x
Are you sure you want to change the base?
Conversation
…pport This commit significantly overhauls the Temporal connection configuration system. The previous configuration was limited to specifying a single Temporal address with no support for SSL connections. With the new setup, developers can now define multiple connection options, including SSL-enabled connections. Changes include: - Introduction of a 'connections' array to specify multiple connection types (e.g., `default`, `SSL`). - Addition of the `SslConnection` class to handle SSL connection parameters such as certificates and keys. - Preservation of backward compatibility by supporting the previous `address` configuration under the `default` connection type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #83 +/- ##
============================================
- Coverage 99.14% 98.68% -0.47%
- Complexity 103 110 +7
============================================
Files 15 18 +3
Lines 352 380 +28
============================================
+ Hits 349 375 +26
- Misses 3 5 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Aleksei Gagarin <[email protected]>
Co-authored-by: Aleksei Gagarin <[email protected]>
Co-authored-by: Aleksei Gagarin <[email protected]>
@@ -6,6 +6,9 @@ | |||
|
|||
class Connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class Connection | |
class InsecureConnection |
See temporalio/sdk-php#410 |
Co-authored-by: Aleksei Gagarin <[email protected]>
This PR introduces the ability to configure multiple connections to Temporal servers, including SSL-enabled connections. It aims to provide greater flexibility and security in connection setup, improving upon the previous single-address configuration approach.
Key Changes
SslConnection
for SSL-specific settings.Previous Configuration:
**New Configuration:
Motivation
Enhancing security and deployment flexibility by supporting SSL connections and allowing configurations to adapt dynamically to different environments.
Testing & Backward Compatibility