Code refactoring

[butschster]

We've made a strategic decision to improve the developer experience (DX) within the temporal/sdk PHP package rather than in the integration bridge package itself. This approach simplifies the structure and focuses on making the SDK more user-friendly for developers.

The spiral/temporal-bridge package will now primarily serve to facilitate the integration with the Spiral framework, avoiding additional complexities. This streamlines the overall setup and usage.

In addition, we've revised the way Workflow and Activity classes are created. Instead of generating both a class and an interface for these, we're now only creating the class. This simplification makes the process more straightforward and efficient.

Here are the updated examples for Activity and Workflow classes in PHP:

For an Activity class:

Command:

php app.php create:activity Payment --method=pay --method=refund:void --method=getPaymentStatus:bool

Result:

<?php

declare(strict_types=1);

namespace Spiral\Testing\Endpoint\Temporal\Activity;

use React\Promise\PromiseInterface;
use Temporal\Activity\ActivityInterface;
use Temporal\Activity\ActivityMethod;

#[ActivityInterface]
class PaymentActivity
{
    /**
     * @return PromiseInterface<mixed>
     */
    #[ActivityMethod(name: 'pay')]
    public function pay(): mixed
    {
        // TODO: Implement activity method
    }

    /**
     * @return PromiseInterface<void>
     */
    #[ActivityMethod(name: 'refund')]
    public function refund(): void
    {
        // TODO: Implement activity method
    }

    /**
     * @return PromiseInterface<bool>
     */
    #[ActivityMethod(name: 'getPaymentStatus')]
    public function getPaymentStatus(): bool
    {
        // TODO: Implement activity method
    }
}

For a Workflow class:

Command:

php app.php create:workflow Payment --query-method=getPayment:string' --query-method=getTotal:int --signal-method=pay

Result:

<?php

declare(strict_types=1);

namespace Spiral\Testing\Endpoint\Temporal\Workflow;

use Temporal\Workflow\SignalMethod;
use Temporal\Workflow\QueryMethod;
use Temporal\Workflow\WorkflowInterface;
use Temporal\Workflow\WorkflowMethod;

#[WorkflowInterface]
class PaymentWorkflow
{
    /**
     * Handle workflow
     */
    #[WorkflowMethod]
    public function handle()
    {
        // TODO: Implement handle method
    }

    #[QueryMethod]
    public function getPayment(): string
    {
        // TODO: Implement query method
    }

    #[QueryMethod]
    public function getTotal(): int
    {
        // TODO: Implement query method
    }

    #[SignalMethod]
    public function pay(): void
    {
        // TODO: Implement signal method
    }
}

Additionally, we've removed presets from the package. This decision was made because presets are often specific to particular applications and trying to accommodate all potential scenarios was becoming overly complex.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05c7410) 77.45% compared to head (11ef03e) 97.76%.

Additional details and impacted files

@@              Coverage Diff              @@
##                3.x      #75       +/-   ##
=============================================
+ Coverage     77.45%   97.76%   +20.31%     
+ Complexity      198       70      -128     
=============================================
  Files            28       12       -16     
  Lines           683      224      -459     
=============================================
- Hits            529      219      -310     
+ Misses          154        5      -149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.