Fix listener

spiral · May 22, 2024 · 6f54fea · 6f54fea
1 parent 908683b
commit 6f54fea
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/src/DeclarationLocator.php b/src/DeclarationLocator.php
@@ -14,8 +14,8 @@
 use Temporal\Workflow\WorkflowInterface;
 
 #[Singleton]
-#[TargetAttribute(WorkflowInterface::class)]
-#[TargetAttribute(ActivityInterface::class)]
+// #[TargetAttribute(WorkflowInterface::class)]
+// #[TargetAttribute(ActivityInterface::class)]
 final class DeclarationLocator implements
     DeclarationRegistryInterface,
     TokenizationListenerInterface,
@@ -63,13 +63,13 @@ public function listen(\ReflectionClass $class): void
         /** @var DeclarationType|null $type */
         $type = null;
 
-        foreach (\array_merge($class->getInterfaces(), [$class]) as $type) {
-            if ($this->reader->firstClassMetadata($type, WorkflowInterface::class) !== null) {
+        foreach (\array_merge($class->getInterfaces(), [$class]) as $reflection) {
+            if ($this->reader->firstClassMetadata($reflection, WorkflowInterface::class) !== null) {
                 $type = DeclarationType::Workflow;
                 break;
             }
 
-            if ($this->reader->firstClassMetadata($type, ActivityInterface::class) !== null) {
+            if ($this->reader->firstClassMetadata($reflection, ActivityInterface::class) !== null) {
                 $type = DeclarationType::Activity;
                 break;
             }

diff --git a/tests/src/DeclarationLocatorTest.php b/tests/src/DeclarationLocatorTest.php
@@ -181,6 +181,19 @@ class: new \ReflectionClass(TestActivityClassWithInterface::class),
         $this->assertSame(ActivityInterface::class, $result[3][0]);
         $this->assertSame(TestActivityClassWithInterface::class, $result[3][1]->getName());
     }
+
+    public function testWrongClasses(): void
+    {
+        $this->locator->listen(new \ReflectionClass(\stdClass::class));
+
+        $result = [];
+
+        foreach ($this->locator->getDeclarations() as $type => $class) {
+            $result[] = [$type, $class];
+        }
+
+        $this->assertCount(0, $result);
+    }
 }
 
 enum TestEnum