-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concurrent writing and reading on workers boot #1137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a shared lock on a file in Memoty::loadData() to prevent reading an empty file while writing it in concurrent worker/process
Also another option is to remove |
wolfy-j
approved these changes
Sep 4, 2024
roxblnfk
approved these changes
Sep 5, 2024
Remove `LOCK_NB` flag to make thread waiting for a lock release instead of returning result
@wapmorgan hi, the first commit was OK. Could you revert the last change? |
Revert commit. Dont block current thread
roxblnfk
reviewed
Sep 6, 2024
roxblnfk
approved these changes
Sep 6, 2024
roxblnfk
changed the title
Update Memory.php
Fix concurrent writing and reading on workers boot
Sep 8, 2024
leon0399
added a commit
to leon0399/spiral-framework
that referenced
this pull request
Sep 29, 2024
Introduced in spiral#1137
leon0399
added a commit
to leon0399/spiral-framework
that referenced
this pull request
Sep 29, 2024
Introduced in spiral#1137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a shared lock on a file in Memoty::loadData() to prevent reading an empty file while writing it in concurrent worker/process
file_put_contents
in\Spiral\Boot\Memory::saveData=>\Spiral\Files\Files::write
created, but not completed write to fileGot this problem when 2 jobs consumers concurrently started writing/reading runtime/cache/cycle.php file. First consumer writing schema to the file, second consumers find out that files exists and read it, but it still was empty = so read empty schema.