Update scaling-with-hpa.md #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the duplicate hpa example yaml, and updated the yaml to reflect an upgrade done on PR spinkube/spin-operator#268 Signed-off-by: asteurer <[email protected]>
|
Thanks @asteurer. The documentation is intended to reflect the latest version of Spinkube. Because spinkube/spin-operator#268 has not yet made it into a release, we should hold off on publishing this until a new version of Spinkube (with an updated version of spin-operator) has been released. Otherwise users will try to run these commands and will fail because the quickstart guide currently suggests that the user should install spin-operator v0.2.0. |
| @@ -167,7 +124,7 @@ metadata: | |||
| spec: | |||
| image: ghcr.io/spinkube/spin-operator/cpu-load-gen:20240311-163328-g1121986 | |||
| executor: containerd-shim-spin | |||
| enableAutoscaling: true | |||
| replicas: 1 | |||
There was a problem hiding this comment.
With minReplicas and maxReplicas set, isn't this redundant?
EDIT: raised feedback in the upstream PR.
|
New location: spinkube/spin-operator#270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the duplicate hpa example yaml, and updated the yaml to reflect an upgrade done on PR spinkube/spin-operator#268