Skip load_instance_pre for components not referenced by the trigger
#3280
+775
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
approved these changes
Oct 3, 2025
And indeed, I ran into the same issue in that pursuit just now. Thank you for fixing this! |
This allows the manifest to contain components which exist only to be used in composition and do not necessarily comply with the Spin world - albeit more important for future middleware-style projects than for current import-style dependencies. Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
skip-loading-unused-components
branch
from
18072f3 to
3f2882f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arose from prototyping WASI P3 middleware. It was convenient to represent my middleware components as untriggered Spin components so they could participate in
spin build, but then the app wouldn't load because the middleware components importednext(akaorigin), which Spin couldn't satisfy.I do worry that this solution might have unintended consequences, since it puts our instance map out of sync with our component list. If we're concerned, I can close this and build my middleware using additional
build.commands and avoid the Spin components. But I think Till wants to be able to build library components within Spin anyway? So we may need to figure it out at some point anyway.Anyway very open to thoughts...