WIP: rv ruby ci #160
Draft
WIP: rv ruby ci #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
b07b9a1 to
3feb422
Compare
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
d1064ad to
d8124d2
Compare
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
a30a248 to
c2e2fd5
Compare
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
89474b9 to
299823d
Compare
This is optional and defaults to true. Configurable via CLI.
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
299823d to
95ac6b7
Compare
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
7fc6bb6 to
70dbaf0
Compare
Previously, to check the checksums, I was reading the entire file into memory and then hashing it. This obviously can take up a lot more memory than just handling the file one chunk at a time (e.g. reading each entry out of the data.tar.gz and unpacking it). To get the best of both worlds, I introduced a hashing reader, which computes the sha256 and sha512 hashes as we're reading from the data source. Then we finalize it at the end.
adamchalmers
force-pushed
the
achalmers/ruby-ci
branch
from
58cc895 to
51e82e3
Compare
The previous file didn't have any checksum section. So it didn't get good test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.