Remove github.com/zeebo/errs dependency #5716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really use this dependency for much other than to group some errors together with a common error message prefix. The same can now be accomplished with a couple custom error types and the `errors` standard library package. This package also wasn't consistently adopted throughout the project, so at this point it's probably better to just rely on the standard library functionality, since it's sufficient for the project's use cases. Signed-off-by: Ryan Turner <[email protected]>
rturner3
requested review from
evan2645,
amartinezfayo,
azdagron and
MarcosDY
as code owners
Signed-off-by: Ryan Turner <[email protected]>
| } | ||
| if c.JWTIssuer != "" { | ||
| jwtIssuer, err := url.Parse(c.JWTIssuer) | ||
| if err != nil || jwtIssuer.Scheme == "" || jwtIssuer.Host == "" { | ||
| return nil, errs.New("the jwt_issuer url could not be parsed") | ||
| return nil, errors.New("the jwt_issuer url could not be parsed") |
There was a problem hiding this comment.
Could we also include the error in here and maybe the jwtIssuer?
| @@ -300,7 +300,7 @@ func migrateDB(db *gorm.DB, dbType string, disableMigration bool, log logrus.Fie | |||
| dbCodeVersion, err := getDBCodeVersion(*migration) | |||
| if err != nil { | |||
| log.WithError(err).Error("Error getting DB code version") | |||
| return sqlError.New("error getting DB code version: %v", err) | |||
| return newSQLError("error getting DB code version: %v", err) | |||
There was a problem hiding this comment.
Would this be better in any way with newWrappedSQLError(fmt.Errorf("error getting DB code version: %w", err))? I think it might be better for use with errors.Is.
| @@ -250,6 +250,7 @@ func (s *PluginSuite) TestBundleCRUD() { | |||
|
|
|||
| // fetch non-existent | |||
| fb, err := s.ds.FetchBundle(ctx, "spiffe://foo") | |||
| s.T().Logf("err type: %T", err) | |||
There was a problem hiding this comment.
Is this a debug leftover?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really use this dependency for much other than to group some errors together with a common error message prefix. The same can now be accomplished with a couple custom error types and the
errorsstandard library package.This package also wasn't consistently adopted throughout the project, so at this point it's probably better to just rely on the standard library functionality, since it's sufficient for the project's use cases.
Fixes #5631.