Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zeebo dependency #5631

Open
MarcosDY opened this issue Nov 5, 2024 · 3 comments · May be fixed by #5716
Open

Remove zeebo dependency #5631

MarcosDY opened this issue Nov 5, 2024 · 3 comments · May be fixed by #5716
Assignees
@rturner3
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@MarcosDY
Copy link
Collaborator

MarcosDY commented Nov 5, 2024

The zeebo/errs dependency is no longer serving its intended purpose in the plugins, as our use case has evolved. A new version, zeebo/errs v2, is available, aligning with updated error-handling standards. However, given that:

  • We no longer rely on classes (now referred to as tags),
  • There's no longer a need to attach metadata to errors,

we should evaluate whether to upgrade to zeebo/errs v2 or remove the dependency entirely. My recommendation is to remove the dependency if there’s no clear benefit in adopting the new version.
@MarcosDY MarcosDY added triage/in-progress Issue triage is in progress triage/needed Issue is in need of triage and removed triage/in-progress Issue triage is in progress labels Nov 5, 2024
@azdagron
Copy link
Member

azdagron commented Nov 5, 2024

I think we're in agreement that we can just remove this dependency.

@azdagron azdagron added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog and removed triage/needed Issue is in need of triage labels Nov 5, 2024
@edwbuck
Copy link
Contributor

edwbuck commented Nov 7, 2024

Are we seeking to preserve or remove the stack trace output that Zeebo adds silently as part of its error handling?

@rturner3
Copy link
Collaborator

Are we seeking to preserve or remove the stack trace output that Zeebo adds silently as part of its error handling?

We never really used this feature of github.com/zeebo/errs. You have to include a + in the format directive of the errors you create for the library to include the stack trace (documented in this section of the package). There is only one case in the codebase where we are doing this, and it's in a unit test.

Not using this feature is also a primary reason why we think it's probably best to just remove this dependency. I think at some point there was an intention to include stack traces into errors, but we never ended up utilizing it.

@rturner3 rturner3 linked a pull request Dec 14, 2024 that will close this issue
Open
@rturner3 rturner3 self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rturner3 rturner3

Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove github.com/zeebo/errs dependency rturner3/spire
4 participants
@MarcosDY @edwbuck @azdagron @rturner3