Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error logging levels #464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix error logging levels #464

wants to merge 1 commit into from

Conversation

faisal-memon
Copy link
Contributor

Fixes some issues introduced with #388 (configurable logging levels)

  • Restores the -zap-xxxx cli options by moving the opts.BindFlags() call back above flag.Parse()
  • Sets up the logger with zap defaults prior to reading in the config so that errors reading config will be logged again
  • Adds a default log level of info
  • Ensures cli log level settings take precedence over config file

@faisal-memon
Fix error logging levels
139d265 
Signed-off-by: Faisal Memon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azdagron azdagron Awaiting requested review from azdagron azdagron is a code owner

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faisal-memon