Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Buildfix for mvn compile -P static #46

Merged
merged 3 commits into from
Jun 4, 2018
Merged

Buildfix for mvn compile -P static #46

merged 3 commits into from
Jun 4, 2018

Conversation

VijayKrishna
Copy link
Member

Fixing #44. Two stage change (copying notes from commit notes):

Change to Blinky Util

  • Jump was a separate project that I created to factor out some
    grpah related utilites around static analysis. I am now adding
    these utlities to Util so that Blinky does not depend on yet
    another project outside gh/spideruci/blinky.
  • I had to modify the compiler setting for Util from 1.7 -> 1.8,
    since I was using a few lambdas in Jump. Added a different task
    to track the work needed to upgrade Blinky to Java 8: see Upgrade all compiler settings from 1.7 -> 1.8 #45
  • Testing: Build passing on the following commands:
    mvn clean && mvn compile && mvn test

Change to Blinky Statik

Migrating from Jump to Blinky Util for all Graph related utilites
that were earlier housed in Jump (see gh/vijaykrishna/jump).

Testing: Build passing on the following commands:
mvn clean -P statik
mvn compile -P statik
mvn test -P statik

- Jump was a separate project that I created to factor out some
  grpah related utilites around static analysis. I am now adding
  these utlities to Util so that Blinky does not depend on yet
  another project outside gh/spideruci/blinky.
- I had to modify the compiler setting for Util from 1.7 -> 1.8,
  since I was using a few lambdas in Jump. Added a different task
  to track the work needed to upgrade Blinky to Java 8.
- Testing: Build passing on the following commands:
  `mvn clean && mvn compile && mvn test`
Migrating from Jump to Blinky Util for all Graph related utilites
that were earlier housed in Jump (see gh/vijaykrishna/jump).

Testing: Build passing on the following commands:
mvn clean -P statik
mvn compile -P statik
mvn test -P statik
@kajdreef
Copy link
Member

kajdreef commented Jun 4, 2018

Looks good, I tested the changes the changes and have been able to compile and run all the tests without any problems. I will merge it now. Thank you!

@kajdreef kajdreef merged commit cfd3ea0 into master Jun 4, 2018
@kajdreef kajdreef deleted the buildfix branch June 4, 2018 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants