-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Upgrade to codecov v4 #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cclauss I really appreciate your effort, but if it doesn't work out in a reasonable amount of time, I think it might not be worth it. Maybe it's really a bug in the upstream action which will be resolved in the future. For the moment, v3 should work just fine for us 🥲
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
===========================================
- Coverage 100.00% 99.64% -0.36%
===========================================
Files 10 20 +10
Lines 328 559 +231
===========================================
+ Hits 328 557 +229
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
Snap! |
c0c8ff7
to
f735bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for figuring that out!
Maybe we have to exclude setup.py
explicitly from the coverage report to not get a decrease in coverage?
In my opinion, this is justified, since the setup itself is usually never covered by the unit tests, right?
875b86f
to
8339a13
Compare
|
Right, I'm also fine with removing it. 👍 |
Let's not lose |
Short description
GitHub Actions: Upgrade to codecov v4
Proposed changes
Resolved issues
Fixes: #69