Remove type check overrides for test_build_gettext #13299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
commented
Feb 5, 2025
| # regression test for #976 | ||
| app.build(filenames=[app.srcdir / 'index_entries.txt']) | ||
| app.build(filenames=[str(app.srcdir / 'index_entries.txt')]) |
There was a problem hiding this comment.
app.build is hinted as taking strings for filenames.
adamtheturtle
commented
Feb 5, 2025
| @@ -96,7 +100,7 @@ def test_msgfmt(app): | |||
| 'msgfmt', | |||
| 'en_US.po', | |||
| '-o', | |||
| Path('en', 'LC_MESSAGES', 'test_root.mo'), | |||
| str(Path('en', 'LC_MESSAGES', 'test_root.mo')), | |||
There was a problem hiding this comment.
subprocess.run can take Paths. However, the args variable was previously defined without a type hint and so mypy understands it to be list[str]. We can either do the casting here or set args: list[str | Path] = [...] earlier. I chose this but I'm not concerned either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.