-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no trailing comma in multi-line signatures by default #12975
base: master
Are you sure you want to change the base?
Conversation
@TLouf Can you fix the conflicts and then request me for review please? |
- C and C++ domains will never feature a trailing comma as it'd correspond to incorrect syntax. - Python and JS get a new config value to optionally disable the trailing comma
a272868
to
0887051
Compare
@picnixz Done, I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add tests for PEP 695 as well or do you want me to take care of that later (I don't know when)?
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Jakob Lykke Andersen <[email protected]>
I've just added one for the HTML writer, but since there isn't any for the text writer I'm not sure whether to add both the base test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this PR, but this looks good. Can you resolve the conflicts please? (most of the conflicts arise because we are formatting everything now so you can run the make rule to autoformat this (I don't remember which one))
Subject: no trailing comma in multi-line signatures by default
Feature or Bugfix
Relates