Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated yaml and readme #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated yaml and readme #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ Online documentation for Ember is located at `<https://speth.github.io/ember-doc
Installation from source
------------------------

For windows computers make sure that you have installed build tools `C++ build tools <https://visualstudio.microsoft.com/visual-cpp-build-tools>`
This must be installed manually
Comment on lines +25 to +26
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For windows computers make sure that you have installed build tools `C++ build tools <https://visualstudio.microsoft.com/visual-cpp-build-tools>`
This must be installed manually
For Windows computers, make sure that you have installed `Microsoft C++ Build Tools <https://visualstudio.microsoft.com/visual-cpp-build-tools>`_.
This must be installed manually.


The easiest way to compile and install Ember is to use `conda-forge` to provide all
dependencies beyond the base C++ compiler. After installing a Conda distribution such as
`Miniforge <https://github.com/conda-forge/miniforge/releases>`_, you can install these
Expand Down
13 changes: 7 additions & 6 deletions environment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@
channels:
- conda-forge
dependencies:
- cantera ==3.0.*
- libcantera-devel ==3.0.*
- python >=3.8
- scons >=4.0
- boost-cpp >=1.70
- sundials >=6.0
- cantera==3.0.*
- cxx-compiler==1.7.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for pinning this specific version of cxx-compiler?

- libcantera-devel==3.0.*
- python>=3.8
- scons>=4.0
- boost-cpp>=1.70
- sundials>=6.0
- fmt
- tbb
- tbb-devel
Expand Down