Simplify spoiler regex (#125)

This fixes an issue where trailing characters after the spoiler would severely effect performance. Fixes #123
spenserblack · Mar 18, 2023 · a67f422 · a67f422 · vercel · Mar 18, 2023
1 parent 621c3bf
commit a67f422
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/steamdown/__tests__/main.test.ts b/packages/steamdown/__tests__/main.test.ts
@@ -38,11 +38,6 @@ describe("formatting", () => {
     test("exclamation outside of spoiler", () => {
       expect(parse("!!!spoiler text!!!\\!")).toBe("[spoiler]spoiler text[/spoiler]!");
     });
-    test("spoiler with newlines", () => {
-      expect(parse("!!!spoiler\nthis\ntext!!!")).toBe(
-        "[spoiler]spoiler\nthis\ntext[/spoiler]",
-      );
-    });
   });
 
   describe("Literal text", () => {

diff --git a/packages/steamdown/src/extensions.ts b/packages/steamdown/src/extensions.ts
@@ -69,7 +69,7 @@ const spoiler: Extension = {
     return src.match(/!!!/)?.index as number;
   },
   tokenizer(src: string): SpoilerToken | void {
-    const match = src.match(/^!!!((?:.+\n|.*)*[^\n])!!!/);
+    const match = src.match(/^!!!([^\n]*)!!!/);
     if (match) {
       return {
         type: "spoiler",