Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cluster scanner first commit #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

docs: cluster scanner first commit #2

wants to merge 6 commits into from

Conversation

caroldelwing
Copy link

Describe the Change

This PR adds a tool that uses the Palette Go SDK to find clusters running for more than 24 hours.

Checklist

  • README updated?

  • Content added contains comments that explain the purpose of the script and usage.

@caroldelwing caroldelwing requested a review from a team as a code owner October 29, 2024 14:11
addetz
addetz reviewed Oct 29, 2024
View reviewed changes
Copy link

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you comments around style and organization, but I'm so impressed with your Go knowledge. Let me know if you want to chat about anything ❤️

scripts/cluster-scanner/README.md Outdated Show resolved Hide resolved
scripts/cluster-scanner/README.md Outdated Show resolved Hide resolved
scripts/cluster-scanner/README.md Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/format_age.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/format_age.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/search_old_clusters.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/search_old_clusters.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/search_old_clusters.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/main.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/search_clusters.go Outdated Show resolved Hide resolved
karl-cardenas-coding
karl-cardenas-coding approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @caroldelwing

scripts/cluster-scanner/internal/search_old_clusters.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/format_age.go Show resolved Hide resolved
scripts/cluster-scanner/internal/search_old_clusters_test.go Outdated Show resolved Hide resolved
scripts/cluster-scanner/internal/search_old_clusters.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addetz addetz addetz left review comments

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caroldelwing @karl-cardenas-coding @addetz