Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update cilium parameter descriptions and agent mode steps for EKS Hybrid Nodes #5605

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

benradstone
Copy link
Contributor

@benradstone benradstone commented Jan 30, 2025

Describe the Change

This PR fixes some descriptions for the Cilium configuration during EKS Hybrid Nodes - Cluster Import steps. It also fixes the steps to enable agent mode when configuring the hybrid node pool cluster profile.

Changed Pages

💻 Import EKS Cluster and Enable Hybrid Mode
💻 Create Hybrid Node Pools

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@benradstone benradstone added auto-backport Enable backport backport-version-4-5 Backport changes to the version-4-5 branch. labels Jan 30, 2025
@benradstone benradstone requested a review from a team as a code owner January 30, 2025 18:10
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 929445d
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/679bcf2d53e2d70008a48066
😎 Deploy Preview https://deploy-preview-5605--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benradstone benradstone changed the title docs: update cilium parameter descriptions for EKS Hybrid Nodes docs: update cilium parameter descriptions and agent mode steps for EKS Hybrid Nodes Jan 30, 2025
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good :)

@benradstone benradstone merged commit ba635c3 into master Jan 30, 2025
15 checks passed
@benradstone benradstone deleted the fix-eks-hybrid-cilium-parameters branch January 30, 2025 19:27
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 30, 2025
…KS Hybrid Nodes (#5605)

* docs: update cilium parameter descriptions for EKS Hybrid Nodes

* ci: auto-formatting prettier issues

* docs: correct agent mode selection steps

* ci: auto-formatting prettier issues

(cherry picked from commit ba635c3)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 30, 2025
…KS Hybrid Nodes (#5605) (#5606)

* docs: update cilium parameter descriptions for EKS Hybrid Nodes

* ci: auto-formatting prettier issues

* docs: correct agent mode selection steps

* ci: auto-formatting prettier issues

(cherry picked from commit ba635c3)

Co-authored-by: Ben Radstone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-5 Backport changes to the version-4-5 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants