Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add delete node pool section #5569

Merged
merged 8 commits into from
Jan 30, 2025
Merged

docs: add delete node pool section #5569

merged 8 commits into from
Jan 30, 2025
+53 −65

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Jan 27, 2025 •
edited
Loading

Describe the Change

This PR adds a new "Delete Node Pool" section to the Node Pool page.
Additionally, this PR deletes the Reconfigure page (and adds a redirect rule), as it is a duplicated and outdated version of the Node Pool page.

Changed Pages

💻 Node Pools

Jira Tickets

🎫 PCP-4038

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Jan 27, 2025
@caroldelwing caroldelwing marked this pull request as ready for review January 27, 2025 17:10
@caroldelwing caroldelwing requested a review from a team as a code owner January 27, 2025 17:10
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 26daa3e
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/679b76a769f43600082ada10
😎 Deploy Preview https://deploy-preview-5569--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@caroldelwing caroldelwing requested a review from addetz January 30, 2025 13:03
@caroldelwing caroldelwing merged commit d2cd868 into master Jan 30, 2025
15 checks passed
@caroldelwing caroldelwing deleted the pcp-4038-delete-node-pool branch January 30, 2025 13:17
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 30, 2025
@caroldelwing
docs: add delete node pool section (#5569)
dd2639e 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
(cherry picked from commit d2cd868)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jan 30, 2025
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- chore: PAC-938-packs data initial fetch and component development for readme (#3178)
- docs: VMO refactor (#3040)
- Create, style, and populate the Tutorials section (#2689)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- chore: PAC-938-packs data initial fetch and component development for readme (#3178)
- docs: VMO refactor (#3040)
❌ version-4-3 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-3:
- chore: PAC-938-packs data initial fetch and component development for readme (#3178)
- docs: VMO refactor (#3040)
- Security Bulletin Changes (#3120)
❌ version-4-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-4:
- fix: Release 4.4.c (#3723)
- chore: PAC-938-packs data initial fetch and component development for readme (#3178)
- Create, style, and populate the Tutorials section (#2689)
✅ version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 5569

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 30, 2025
@vault-token-factory-spectrocloud @caroldelwing
docs: add delete node pool section (#5569) (#5597)
fe0a02c 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
(cherry picked from commit d2cd868)

Co-authored-by: caroldelwing <[email protected]>
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569)
41f5a7f 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
@caroldelwing caroldelwing mentioned this pull request Jan 30, 2025
Merged
2 tasks
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569) (#5599)
d3acdcb 
* docs: add delete node pool section (#5569)

* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove extra redirect rule from 4-4

---------

Co-authored-by: Adelina Simion <[email protected]>
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569)
0b2d5af 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
@caroldelwing caroldelwing mentioned this pull request Jan 30, 2025
Merged
2 tasks
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569)
5306d6a 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
@caroldelwing caroldelwing mentioned this pull request Jan 30, 2025
Merged
2 tasks
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569)
594c918 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
@caroldelwing caroldelwing mentioned this pull request Jan 30, 2025
Merged
2 tasks
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569)
247d941 
* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
@caroldelwing caroldelwing mentioned this pull request Jan 30, 2025
Merged
2 tasks
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
[version 4-3] docs: add delete node pool section (#5569) (#5600)
460551e 
* docs: add delete node pool section (#5569)

* docs: add delete node pool section

* Apply suggestions from code review

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>

* docs: remove extra redirects

---------

Co-authored-by: Adelina Simion <[email protected]>
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569) (#5601)
4163eda 
* docs: add delete node pool section

* Apply suggestions from code review



* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569) (#5602)
b86d070 
* docs: add delete node pool section

* Apply suggestions from code review



* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
caroldelwing added a commit that referenced this pull request Jan 30, 2025
@caroldelwing @addetz
docs: add delete node pool section (#5569) (#5603)
2d69476 
* docs: add delete node pool section

* Apply suggestions from code review



* docs: remove reconfigure page

* docs: improve deletion warning

---------

Co-authored-by: Adelina Simion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addetz addetz addetz approved these changes

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caroldelwing @addetz