-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History of Transformations based on operation instances #157
base: staging
Are you sure you want to change the base?
Conversation
…ngs and toComment behaviour
@@ -0,0 +1,28 @@ | |||
import { Joinpoint } from "../../Joinpoints.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be moved to the lara-framework repo. It needs to have a generic parameter for the join point that extends LaraJoinPoint, then the weaver generator can specialize to the join point of the specific compiler it is generating code for.
import { DetachOperation, DetachReference, InlineCommentOperation, InsertOperation, RemoveChildrenOperation, ReplaceOperation, SetChildOperation, TypeChangeOperation, ValueOperation } from "../history/Operations.js"; | ||
import { Joinpoint } from "../../Joinpoints.js"; | ||
|
||
const eventListener = new EventEmitter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a global event listener, instantiated by a class in in the lara-framework repo, and other libraries/code register events to that event listener.
Only a small part of this file should be moved to the lara-framework, the part that imports the EventEmitter and instantiates it, it should provide an EventListener class (or LaraEventListener) with a static method that returns the global event listener, and possibly some utility methods (if it makes sense).
History of Transformations based on operation instances
Features
Remaining Topics (before merging)
Analyze the Joinpoint action replaceWith(Joinpoint[]) as it is causing some issuesChange the return values of setFirstChild and setLastChild from void to the Joinpoint that previously existed thereReferences