Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove return loan button from query builder #6340

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Remove return loan button from query builder #6340

wants to merge 1 commit into from
+0 −265

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Mar 19, 2025 •
edited
Loading

Fixes #5003

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)

Testing instructions

  • Go to queries
  • Select loan preparation table
  • Verify there is no button return loan

TODO:
In the case it was on discourse, need to remove it

@CarolineDenis CarolineDenis added this to the 7.10.3 milestone Mar 19, 2025
@CarolineDenis CarolineDenis requested review from acwhite211, sharadsw and a team March 19, 2025 18:49
emenslin
emenslin approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify there is no button return loan

Looks good, button is gone.

@emenslin emenslin requested a review from a team March 19, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emenslin emenslin emenslin approved these changes

@acwhite211 acwhite211 Awaiting requested review from acwhite211

@sharadsw sharadsw Awaiting requested review from sharadsw

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: 📋Back Log
Milestone
7.10.3
Development

Successfully merging this pull request may close these issues.

Return loan records button in query builder throws error
2 participants
@CarolineDenis @emenslin