Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tree actions in view mode #6337

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

Disable tree actions in view mode #6337

wants to merge 2 commits into from
+10 −7

Conversation

CarolineDenis
Copy link
Contributor

Fixes #5007

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Login to or create a user that has tree permissions
  • Go to a tree
  • Enable read-only mode
  • Verify tree actions are disabled

@CarolineDenis CarolineDenis added this to the 7.10.3 milestone Mar 19, 2025
@CarolineDenis CarolineDenis requested a review from sharadsw March 19, 2025 18:02
@CarolineDenis CarolineDenis requested review from acwhite211 and a team March 19, 2025 18:02
emenslin
emenslin reviewed Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify tree actions are disabled

Looks good

@emenslin emenslin requested a review from a team March 19, 2025 19:06
@CarolineDenis CarolineDenis requested a review from sharadsw March 19, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadsw sharadsw sharadsw approved these changes

@emenslin emenslin emenslin approved these changes

@acwhite211 acwhite211 Awaiting requested review from acwhite211

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: 📋Back Log
Milestone
7.10.3
Development

Successfully merging this pull request may close these issues.

Tree actions remain accessible in read-only mode
4 participants
@CarolineDenis @sharadsw @emenslin @acwhite211