-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isPrimary from uniq field for carry & clone config #6331
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify you can check and uncheck isPrimary field
- Verify the isPrimary as been carried over for the collector
isPrimary is hidden in the carry forward config even though it is unhidden in the schema config
03-18_11.28.mp4
@emenslin, it's because isPrimary has the property override { visibility: 'hidden' } in the code |
@CarolineDenis, changing it would be great! I think since we are adding the ability to check and uncheck it that it should not be hidden so users can see the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify you can check and uncheck isPrimary field
- Verify the isPrimary as been carried over for the collector
After discusssing how unhiding isPrimary would break other things it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify you can check and uncheck isPrimary field
- Verify the isPrimary as been carried over for the collector
Everything worked fine on my end. 👍
Fixes #6229
Checklist
self-explanatory (or properly documented)
Testing instructions
Notes:
Since isPrimary field has an override attribute hidden=true in our code even if you uncheck is hidden in the schema config (which will affect other places) it will still stays a hidden field in this context