Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isPrimary from uniq field for carry & clone config #6331

Open
wants to merge 4 commits into
base: production
Choose a base branch
from

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Mar 17, 2025

Fixes #6229

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Open Collecting Event data entry form
  • Add required field
  • Add a collector
  • Set its isPrimary field to true
  • Save
  • Open the carry forward config dialog
  • Open the carry forward config dialog for the relationship Collector
  • Verify you can check and uncheck isPrimary field
  • Keep is primary checked
  • Carry forward the record
  • Verify the isPrimary as been carried over for the collector

Notes:
Since isPrimary field has an override attribute hidden=true in our code even if you uncheck is hidden in the schema config (which will affect other places) it will still stays a hidden field in this context

@CarolineDenis CarolineDenis added this to the 7.10.3 milestone Mar 17, 2025
@CarolineDenis CarolineDenis requested review from sharadsw, acwhite211 and a team March 17, 2025 20:19
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify you can check and uncheck isPrimary field
  • Verify the isPrimary as been carried over for the collector

isPrimary is hidden in the carry forward config even though it is unhidden in the schema config

03-18_11.28.mp4

@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Mar 18, 2025

@emenslin, it's because isPrimary has the property override { visibility: 'hidden' } in the code
So even if you change it in the schema config (which will affect other places) it will not change the hidden property in this config dialog.

@emenslin
Copy link
Collaborator

@CarolineDenis, changing it would be great! I think since we are adding the ability to check and uncheck it that it should not be hidden so users can see the change

@CarolineDenis CarolineDenis requested a review from emenslin March 18, 2025 17:06
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify you can check and uncheck isPrimary field
  • Verify the isPrimary as been carried over for the collector

After discusssing how unhiding isPrimary would break other things it looks good

@emenslin emenslin requested a review from a team March 18, 2025 17:52
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify you can check and uncheck isPrimary field
  • Verify the isPrimary as been carried over for the collector

Everything worked fine on my end. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Dev Attention Needed
Development

Successfully merging this pull request may close these issues.

Collector isPrimary field cannot be cloned or carried forward
3 participants