-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nested to-many in Workbench #6216
base: issue-6127
Are you sure you want to change the base?
Conversation
Triggered by 82033cd on branch refs/heads/issue-2331
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Test upload
- Verify data was uploaded correctly (you can verify through queries)
- Test rollback
Looks good! I tested CO -> Determination -> DeterminationCitation
and CO -> Preparation -> PreparationAttribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Test upload
- Verify data was uploaded correctly (you can verify through queries)
- Test rollback
Looks good, it seems like the RS owner issue was reintroduced in this PR though.
Issue branch:
03-05_14.14.mp4
Production:
03-05_14.20.mp4
@emenslin Should be fixed now. The branch didn't have the latest production changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Test upload
- Verify data was uploaded correctly (you can verify through queries)
- Test rollback
Looks good now!
Fixes #2331
Warning
This PR is based on #5417. Use either a db that was used to test #5417 or create a new db
This PR enables nested to many in the data mapper and fixes some automated tests. The underlying backend support for nested to many is in #5417.
For reference:
Nested to-manys in the workbench are mapping lines that involve multiple to-many relationships. For example:
Collection Object -> Determination (to many) -> DeterminationCitation (to-many) -> ...
Checklist
self-explanatory (or properly documented)
Testing instructions
CO -> Determination -> DeterminationCitation
(see above)CO -> Preparation -> PreparationProperty
CO -> Preparation -> PreparationAttribute