Skip to content

Allow URLs with capital letters#833

Closed
CsatariGergely wants to merge 4 commits into
spdx:mainfrom
nokia:fix-832
Closed

Allow URLs with capital letters#833
CsatariGergely wants to merge 4 commits into
spdx:mainfrom
nokia:fix-832

Conversation

@CsatariGergely

Copy link
Copy Markdown

Fixes: #832

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely

Copy link
Copy Markdown
Author

The Java validator allows URLs with capitals.

@armintaenzertng

Copy link
Copy Markdown
Collaborator

Thanks for catching and fixing this!

Would you mind adding appropriate test cases to the test_valid_url test to document this behavior?

@CsatariGergely

Copy link
Copy Markdown
Author

Humm, I would need some help with the testing @armintaenzertng . It looks like if I run pytest in my dev branch it is not running my modified code. I did pip3 install the local folder before, but still it seems that my changes are not running. Can you help me to figure this out?

@CsatariGergely

Copy link
Copy Markdown
Author

@meretp can you help me with this testing issue?

@meretp

meretp commented May 26, 2025

Copy link
Copy Markdown
Collaborator

@CsatariGergely sure, what exactly did you try? I don't see a test on this branch so I can't really reproduce your issue right now, did you follow the instructions from the Contributing.md file?

@meretp

meretp commented May 26, 2025

Copy link
Copy Markdown
Collaborator

also, it would be good if you could rebase your changes on main and not merge the changes from main into this branch to keep the history clean

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely

Copy link
Copy Markdown
Author

@meretp Thanks I think I've figured out the tests. I just did not know where to add an URI with capitals to test.
I've rebased to current main.

@CsatariGergely

Copy link
Copy Markdown
Author

@meretp , @armintaenzertng what else is missing to get this merged?

@armintaenzertng

armintaenzertng commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Sorry for the long wait, @CsatariGergely. I just merged another PR (#826) that fixes the same problem, so we can close this PR.
Nevertheless, thanks for your contribution!

@CsatariGergely

Copy link
Copy Markdown
Author

Thanks @armintaenzertng . In which release #826 will be included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URLs with capital letters fail on the URL check

3 participants