Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese Translation for spdx-3-model repo. #898

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

NorioKobota
Copy link
Contributor

The Entries section of Vocabularies is next to the Metadata section(not translated), so could you check if it is okay to add the Japanese translation like this?
https://github.com/NorioKobota/spdx-3-model/blob/translation-ja-alpha/model/Core/Vocabularies/AnnotationType.md#entries-jp

And this PR is related to spdx/spdx-spec#1138 .

@bact
Copy link
Collaborator

bact commented Oct 21, 2024

Should the language code be ja instead of jp?

Signed-off-by: Norio Kobota <[email protected]>
@bact bact added the Translation:ja Translation for Japanese language label Oct 21, 2024
@bact bact requested review from zvr and goneall October 21, 2024 09:42
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one inconsistency on the language code

model/Core/Classes/Agent.md Show resolved Hide resolved
@zvr
Copy link
Member

zvr commented Nov 13, 2024

Converting this to draft, since it should be merged after 3.0.1 tagging and new branch has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation:ja Translation for Japanese language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants