Improve license parsing error messages #339
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #338 Dependes on updates to the SPDX Models versions 2 and 3 which add a new class "InvalidLicenseExpression" which is used to produce the errors. This changes the behavior of the license parser from throwing an exception to returning an InvalidLicenseExpression where the verify routine will return the error message.
goneall
added a commit
to spdx/spdx-java-model-2_X
that referenced
this pull request
Jul 3, 2025
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
goneall
added a commit
to spdx/spdx-model-to-java
that referenced
this pull request
Jul 3, 2025
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
goneall
added a commit
to spdx/spdx-java-model-2_X
that referenced
this pull request
Jul 3, 2025
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
bact
added
enhancement
goneall
added a commit
to spdx/spdx-model-to-java
that referenced
this pull request
Jul 6, 2025
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338
Dependes on updates to the SPDX Models versions 2 and 3 which add a new class "InvalidLicenseExpression" which is used to produce the errors.
This changes the behavior of the license parser from throwing an exception to returning an InvalidLicenseExpression where the verify routine will return the error message.