Fix bug in cutout #1933
Merged
Fix bug in cutout #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschaad
approved these changes
Feb 11, 2025
phschaad
reviewed
Feb 12, 2025
dace/sdfg/analysis/cutout.py
Outdated
| @@ -1059,7 +1059,7 @@ def _cutout_determine_output_configuration(ct: SDFG, cutout_reach: Set[SDFGState | |||
| check_for_read_after.add(dn.data) | |||
|
|
|||
| original_state: SDFGState = out_translation[state] | |||
| for edge in original_state.parent.out_edges(original_state): | |||
| for edge in original_state.parent.out_edges(original_state.parent_graph): | |||
There was a problem hiding this comment.
@ThrudPrimrose Off the top of my head, I think this actually needs more adaptation: original_state.parent still is an 'old-style' reference to the SDFG the original state belongs to. I believe this may need to be original_state.parent_graph.out_edges(original_state.parent_graph). can you see if that fixes the tests?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in cutout for me.