fix: unable to correctly determine isAlwaysClosed and isAlwaysOpen #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes an issue where the
isAlwaysOpen
andisAlwaysClosed
methods were returning wrong results in cases where exceptions were defined.Consider the following example, where
isAlwaysClosed
would return false:Or this example, where
isAlwaysOpen
would return false:everyExceptions
method for checking conditions on exceptions.isAlwaysClosed
andisAlwaysOpen
methods to respect exceptions.