Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed useless setters #552

Closed
wants to merge 1 commit into from

Conversation

hirohitoqwe
Copy link

Hi! I recently started using this library and found that the priority and changefreq parameters are deprecated. In this regard, I decided to basically remove them from the code.
To be honest, I don't think it would be right to delete these parameters, because there is not only the Google search engine, perhaps these parameters are still relevant in other search engines. I would be happy if you didn't accept my deletion request and rolled back this one: #545
Thank you.

update tests
update xml files for updated tests
@hirohitoqwe hirohitoqwe changed the title Unnecessary setters have been removed Removed useless setters Aug 9, 2024
@tfevens
Copy link

tfevens commented Sep 17, 2024

I agree with @hirohitoqwe - changefreq and priority are not commonly used (by Google) but may be by other search engines. Everything I have read still recommends using them "just in case" and as a guide for a bot. Why not keep them in the code?

If there's a definitive article stating that they are deprecated across all search engines, please link and I'll happily change my mind :-)

@hirohitoqwe
Copy link
Author

My pull request is open from 9.08.2024 :) Still not reviewed

@KreatifBilisim
Copy link

Katılıyorum@hirohitoqwe- changefreq ve priority (Google tarafından) yaygın olarak kullanılmaz ancak diğer arama motorları tarafından kullanılıyor olabilir. Okuduğum her şey hala "her ihtimale karşı" ve bir bot için rehber olarak kullanılmasını öneriyor. Neden bunları kodda tutmuyorsunuz?

Eğer tüm arama motorlarında kullanımdan kaldırıldıklarına dair kesin bir makale varsa lütfen bağlantısını verin, fikrimi memnuniyetle değiştiririm :-)

https://developers.google.com/search/blog/2023/06/sitemaps-lastmod-ping#changefreq-and-priority

@freekmurze
Copy link
Member

I'm going to pass on this for now, since this is technically a breaking change. I'll revisit this when creating a new major version of the package.

@freekmurze freekmurze closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants