Fixed bug of loading user roles of different teams to current team

[mohamedds-12]

Fixes :

• Bug when assigning role to user that has same role in a different team #2802

[drbyte]

It would be best to also add tests for the specific functionality you're trying to fix.

[parallels999]

You are adding extra queries,
That was developed to take advantage of the preloaded relationships when teams are not enabled, this would affect the performance of all of us who do not use teams

There are many notes in the documentation about using unsetRelation in teams, changing teams in the same session is not something that should happen, it is designed to maintain a single team

#1094 (comment)

[cesarreyes3]

You could just do attach directly or syncRoles

$user->roles()->attach($roleIdsArray, $theTeamId);

[mohamedds-12]

@drbyte, @parallels999
I have changed the fix to Reloading user roles before role assigning only if teams feature is enabled to avoid running extra queries when not using teams, And I have changed the Tests accordingly. (I don't think we should worry too much about sql queries in this one cuz it's not like Role-Assignment happens frequently as for ex Role-Checking).

I think it's a logical thing to expect that the package would take into consideration teamSessionId getting changed on the fly as the functionality is supported therefore it should assert to reload user roles before role-assigning (of course only when teams are enabled) as for there is no reason for reloading when not using teams.

I think we should add this functionality as it is not a breaking change and it's been mentioned earlier
and it's an excepted behavior

• Enable Eager Loading Roles/Permissions #1094
• Issue assigning team roles when relationship is preloaded #2553

[parallels999]

Shouldn't the relationship be loaded only if the model already exists?

[drbyte]

I still think this needs some specific tests regarding the problem that's being addressed.

It's probable that the it_can_assign_same_and_different_roles_on_same_user_different_teams test doesn't cover this scenario, so another test that does cover the present problem would be beneficial.