Fix to broken tests for Responsive Media Conversions. (#3743)

* Update ResponsiveImageTest.php

remove incorrect test

* Update ConversionTest.php

add correct tests

tests/Conversions/ConversionTest.php

@@ -24,6 +24,18 @@
     expect($this->conversion->getManipulations()->getManipulationArgument('format'))->toEqual(['png']);
 });
 
+it('will set conversions to responsive', function () {
+    $this->conversion->withResponsiveImages();
+
+    expect($this->conversion->shouldGenerateResponsiveImages())->toBeTrue();
+});
+
+it('will set conversions to not be responsive', function () {
+    $this->conversion->withResponsiveImages()->withResponsiveImages(false);
+
+    expect($this->conversion->shouldGenerateResponsiveImages())->toBeFalse();
+});
+
 it('will be performed on the given collection names', function () {
     $this->conversion->performOnCollections('images', 'downloads');
     expect($this->conversion->shouldBePerformedOn('images'))->toBeTrue();

tests/ResponsiveImages/ResponsiveImageTest.php

@@ -112,18 +112,3 @@
 
     expect($media->getResponsiveImageUrls('non-existing-conversion'))->toBe([]);
 });
-
-test('a media instance can be set to not generate responsive urls', function () {
-    $this
-        ->testModelWithResponsiveImages
-        ->addMedia($this->getTestJpg())
-        ->withResponsiveImages()
-        ->withResponsiveImages(false)
-        ->toMediaCollection();
-
-    $media = $this->testModelWithResponsiveImages->getFirstMedia();
-
-    expect($media->hasResponsiveImages())->toBeFalse();
-
-    expect($media->hasResponsiveImages('thumb'))->toBeFalse();
-});