Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #806

Merged
merged 19 commits into from
Dec 29, 2023
Merged

v4 #806

merged 19 commits into from
Dec 29, 2023

Conversation

freekmurze
Copy link
Member

  • remove dependency on spatie/image
  • clean up internals

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Hugo Alliaume <[email protected]>
@bendbot
Copy link

bendbot commented Dec 29, 2023

spatie/laravel-sitemap has a dependency spatie/crawler: "^8.0.1", which has spatie/browsershot: "^3.45", then spatie/image: "^1.5.3|^2.0"

spatie/laravel-medialibrary version 11 has a dependency spatie/image: "^3.3.2"`

Because of this, it is not possible to use the latest version of laravel-medialibrary together with laravel-sitemap, crawler, browsershot.

Why doesn't this version merge?

@freekmurze freekmurze merged commit 36b90d9 into main Dec 29, 2023
9 checks passed
@freekmurze freekmurze deleted the v4 branch December 29, 2023 12:55
@freekmurze
Copy link
Member Author

@bendbot I've tagged version of spatie/crawler that allows Browsershot v4 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants